Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate babel dependencies in yarn.lock #35712

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Conversation

uladzimirdev
Copy link
Contributor

@uladzimirdev uladzimirdev commented Nov 14, 2023

Description

result of running

npx yarn-deduplicate --scopes @babel

actually resolves multiple versions of the babel packages to the most recent

How to verify

First:

rm -rf node_modules && yarn
  • tests should pass
  • local run should work
  • build should work
  • storybook build should work
  • release build should work

Side effects

Disk space taken

together with #35659 cuts ~1700MB of node_modules

before
image

after
image

Time to install node_modules

Before
Screenshot 2023-11-17 at 11 05 37

After
Screenshot 2023-11-17 at 11 05 26

@uladzimirdev uladzimirdev changed the base branch from master to fix-babel-deps November 14, 2023 14:19
Base automatically changed from fix-babel-deps to master November 14, 2023 18:45
@uladzimirdev uladzimirdev changed the title dedupe babel deps Deduplicate babel dependencies in yarn.lock Nov 14, 2023
@uladzimirdev uladzimirdev added the no-backport Do not backport this PR to any branch label Nov 16, 2023
Copy link

Current Cypress Test Results Summary

✅ 139 Passing - ❌ 1 Failing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 11/16/2023 07:45:06pm UTC)

Run Details

Running Workflow E2E Tests on Github Actions

Commit: a0894b1

Started: 11/16/2023 07:11:54pm UTC

❌ Failures

📄   e2e/test/scenarios/dashboard/x-rays.cy.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > x-rays should correctly apply breakout in query builder (#14648)
Retry 2Retry 1Initial Attempt
Error: Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the ...
Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 1st request to the route: `ordersDataset`. No request ever occurred.

https://on.cypress.io/wait
3.57% (2) 2 / 56 runs
failed over last 7 days
0% (0) 0 / 56 runs
flaked over last 7 days

⚠️ Flakes

📄   e2e/test/scenarios/visualizations-tabular/pivot_tables.cy.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > visualizations > pivot tables should return the same number of rows when running as an ad-hoc query vs a saved card (#34278)
Retry 1Initial Attempt
2.80% (11) 11 / 393 runs
failed over last 7 days
3.82% (15) 15 / 393 runs
flaked over last 7 days

📄   e2e/test/scenarios/dashboard/x-rays.cy.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > x-rays should be able to save an x-ray as a dashboard and visit it immediately (#18028)
Retry 2Retry 1Initial Attempt
0.42% (2) 2 / 477 runs
failed over last 7 days
0.21% (1) 1 / 477 run
flaked over last 7 days

📄   e2e/test/scenarios/dashboard/dashboard-back-navigation.cy.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > dashboard > dashboard back navigation should display a back to the dashboard button in table x-ray dashboards
Retry 1Initial Attempt
0.20% (1) 1 / 489 run
failed over last 7 days
0.61% (3) 3 / 489 runs
flaked over last 7 days

View Detailed Build Results


@uladzimirdev uladzimirdev requested review from iethree and a team November 17, 2023 10:04
@ranquild
Copy link
Contributor

@uladzimirdev great work!

@uladzimirdev uladzimirdev merged commit a1cee62 into master Nov 17, 2023
108 checks passed
@uladzimirdev uladzimirdev deleted the dedupe-babel-deps branch November 17, 2023 19:03
Copy link

@uladzimirdev Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants