Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the ci golint file exists #380

Closed
wants to merge 1 commit into from

Conversation

captain-Akshay
Copy link

@captain-Akshay captain-Akshay commented Oct 2, 2023

Description

This PR fixes #378
reference to github issue where the golangci-lint crew recommends this workaround: golangci/golangci-lint-action#244

Notes for Reviewers
This will increase the time complexity.
skip-pkg-cache: true
skip-build-cache: true
Signed commits

  • Yes, I signed my commits.

Signed-off-by: captain-Akshay <akshay.sharma0503@gmail.com>
@welcome
Copy link

welcome bot commented Oct 2, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@captain-Akshay
Copy link
Author

captain-Akshay commented Oct 2, 2023

@theBeginner86 do let me know your review or feedback!
Thanks!

@leecalcote
Copy link
Member

Running build checks...

@nebula-aac
Copy link
Contributor

@captain-Akshay

Can you run golangci-lint run ./... --fix to fix the formatting issue and update this fork?

@captain-Akshay
Copy link
Author

captain-Akshay commented Oct 3, 2023

@nebula-aac got this error :-

image

& when i commented the unused variable the code golangci-lint run ./... --fix run fine!

Copy link
Member

@theBeginner86 theBeginner86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nebula-aac got this error :-

image

& when i commented the unused variable the code golangci-lint run ./... --fix run fine!

Sounds good to me. Lets remove the un-used occurrences of var.

@theBeginner86 theBeginner86 added the kind/chore Necessary task label Oct 6, 2023
@captain-Akshay
Copy link
Author

captain-Akshay commented Oct 6, 2023

@theBeginner86 actually i checked the whole function and the komposeObject is being used in this file
and the only work around i was able to find was
changing this code:-

komposeObject := kobject.KomposeObject{
		ServiceConfigs: make(map[string]kobject.ServiceConfig),
	}

to

var komposeObject kobject.KomposeObject
komposeObject.ServiceConfigs = make(map[string]kobject.ServiceConfig)

now i might be wrong because I'm newbie in go 😅 but if you have something else do let me know !

this gives out no error while running golangci-lint run ./... --fix

Copy link

stale bot commented Nov 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 21, 2023
Copy link

stale bot commented Dec 1, 2023

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/stale Issue has not had any activity for an extended period of time kind/chore Necessary task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Fix lint issues
4 participants