Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cu 85zrruq0d resolve dependency of hubdockercom #15

Merged

Conversation

florianow
Copy link
Contributor

hey, changed the build process from docker to github. is that workaround docker/build-push-action#461 still needed? I used the newest versions and that issue is closed with a fix. However, anyone should change the secrets, i can't do it?

.github/workflows/release.yml Outdated Show resolved Hide resolved
@JohannesRudolph
Copy link
Member

JohannesRudolph commented Mar 21, 2023

is that workaround docker/build-push-action#461 still needed?

I don't see how that applies with the current build-push action, so we should be good

However, anyone should change the secrets, i can't do it?

secrets.GITHUB_TOKEN is provided by GitHub automatically inside GH Actions runners, so no secrets to configure from our side. Should be good!

@florianow florianow merged commit 868acaf into master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants