fix: patch lodash to not use Function calls

[Yash-Singh1]

📑 Summary

Patch lodash-es and cytoscape (has lodash bundled in it) to avoid using Function calls.

Resolves #5378

📏 Design Decisions

I patched lodash-es to use a globalThis polyfill and for cytoscape I just used window because cytoscape only runs in browser afaik.

This won't fix CSP violations when running Mermaid.js without the bundles (directly importing the ESM mermaid.core.mjs), but it would patch the Function calls in the bundles.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🔖 targeted develop branch

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	9fd6a13
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/65ff34f98009b80008c5b593
😎 Deploy Preview	https://deploy-preview-5408--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.72%. Comparing base (c00bf26) to head (9fd6a13).

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #5408   +/-   ##
=======================================
  Coverage     5.72%   5.72%           
=======================================
  Files          277     277           
  Lines        41896   41896           
  Branches        27      27           
=======================================
  Hits          2400    2400           
  Misses       39495   39495           
  Partials         1       1           

Flag	Coverage Δ
unit	5.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[Yash-Singh1]

I got this working with the example repro provided by @simov on Firefox 124.

@simov Could you confirm that this works on your end too?

[simov]

@Yash-Singh1 sure, can you point me to the mermaid.min.js produced by this PR?

[Yash-Singh1]

@Yash-Singh1 sure, can you point me to the mermaid.min.js produced by this PR?

Sure, here is a link to the mermaid.min.js build: https://mermaid-upload-5408-build.pages.dev/9fd6a13/mermaid.min.js

LMK if you need anything else to get it working.

[simov]

It works in Firefox.

Is this PR on top of v10.9.0? Because it works in Chrome too, meaning the other issue reported here #5383 about the character encoding seems to be resolved too.

[Yash-Singh1]

Is this PR on top of v10.9.0?

Yes, this PR is on top of v10.9.0.

Because it works in Chrome too, meaning the other issue reported here #5383 about the character encoding seems to be resolved too.

Interesting, there must have been a commit between now and the 10.9.0 release that removed the latin characters issue then.

[sidharthv96]

Nice work @Yash-Singh1!
What do you think the long term fix for this would be? Should we raise the issue in lodash repo to see if they would add the polyfill directly?

[Yash-Singh1]

Nice work @Yash-Singh1! What do you think the long term fix for this would be? Should we raise the issue in lodash repo to see if they would add the polyfill directly?

Yeah, I think that would make sense.