Allow Semicolons in Timeline Titles, Sections, Periods, and Events #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Removed the semicolon from the regex for titles, sections, periods, and events. Changes to timeline.spec.js 1. Added a test for the changes made in the timeline parser
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5335 +/- ##
=======================================
Coverage 5.74% 5.74%
=======================================
Files 277 276 -1
Lines 41899 41888 -11
Branches 489 514 +25
=======================================
Hits 2407 2407
+ Misses 39492 39481 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
FutzMonitor
changed the title
sidharthv96
reviewed
Mar 6, 2024
Comment on lines
111
to
125
| timelineDB.getTasks().forEach((t) => { | ||
| switch (t.task.trim()) { | ||
| case ';ta;sk1;': | ||
| expect(t.events).to.deep.equal([';ev;ent1;']); | ||
| break; | ||
|
|
||
| case ';tas;k2;': | ||
| expect(t.events).to.deep.equal([';eve;nt2;', ';event;3;', ';eve;nt4', ';even;t5;']); | ||
| break; | ||
|
|
||
| default: | ||
| break; | ||
| } | ||
| }); | ||
| }); |
There was a problem hiding this comment.
instead of a loop with switch case, it'll be cleaner to access the tasks by index.
1. Re-organized the new TL-6 test to not use a for-loop with a switch case. 2. Imported the commonDb module to ensure titles are be tested. 3. Use indices to retrieve elements that need to be tested.
FutzMonitor
commented
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull request removes the semicolons from the title, section, events, and periods regex so that semicolons can be used in their text content.
Resolves #4175. This doesn't directly address that issue, but I wanted to link it because my ultimate goal is to figure out how to allow colons without them being identified as tokens.
📏 Design Decisions
I simply removed the semicolon symbol from the exclusion clause regex for the title, section, event and period. I almost made sure to add a test to the timeline test suite and run
pnpm testto ensure that it was still working.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch