Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Requirement overflow #5305

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Mikek16
Copy link

@Mikek16 Mikek16 commented Feb 21, 2024

📑 Summary

Changes the charLimit for text wrapping in the requirementRenderer.js from 30 to 24 to stop overflowing.

Resolves #2477

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit a4bbaf0
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/661003685159a200086f51fa
😎 Deploy Preview https://deploy-preview-5305--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Feb 21, 2024
@Mikek16
Copy link
Author

Mikek16 commented Feb 21, 2024

Updated:
working2477

Original:
original2477

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 5.74%. Comparing base (3ccfea8) to head (a4bbaf0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5305   +/-   ##
=======================================
  Coverage     5.74%   5.74%           
=======================================
  Files          277     276    -1     
  Lines        41897   41886   -11     
  Branches       489     514   +25     
=======================================
  Hits          2407    2407           
+ Misses       39490   39479   -11     
Flag Coverage Δ
unit 5.74% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...id/src/diagrams/requirement/requirementRenderer.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@Mikek16 Mikek16 marked this pull request as ready for review February 25, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement Diagram:-If text is long it is going out of box
2 participants