New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mermaidAPI.parse() behavior to match documentation, add tests to ensure behavior matches docs #3004
Merged
Merged
fix mermaidAPI.parse() behavior to match documentation, add tests to ensure behavior matches docs #3004
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8210e3c
add setParseErrorHandler,check for undefined mermaidAPI before using
timmaffett 67b6414
fix parse() to match spec (return true if valid, false if invalid (an…
timmaffett 0df80d2
fix parseError documentation to match reality
timmaffett ca8080a
add more test for mermaidAPI.parse() to ensure it matches documented …
timmaffett f7c28ff
Merge branch 'mermaid-js:develop' into parse_parseError_fixes
timmaffett c8e5525
Merge branch 'develop' into parse_parseError_fixes
timmaffett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knsv @ashishjain0512 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question here was because there are some places in the code that the parseError() method is called as
mermaid.parseError()
and a couple places where it is called as
global.mermaid.parseError()
These two should be identical, but it is more of a stylistic question for the mermaid code base.