feat: add accDescription field to state diagrams #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knsv
changed the title
knsv
approved these changes
Apr 12, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搼 Summary
This PR furthers the effort to make charts accessible (#2732) by adding a accDescription field with the end effect of adding a aria-label-by node in the state diagram SVG. This PR additionally adds a
titlefield, since this is what is expected by the functions inaccessibility.js, but does not yet actually display the title. I can add this in a followup PR.馃搹 Design Decisions
Same implementation as #2747
I've also added tests for the stateDiagram-v2 renderer since they didn't exist, and added an example page using both renderers
馃搵 Tasks
Make sure you
developbranch