Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint html : enable eslint-plugin-html #2531

Merged
merged 2 commits into from
Dec 11, 2021
Merged

lint html : enable eslint-plugin-html #2531

merged 2 commits into from
Dec 11, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Dec 4, 2021

馃搼 Summary

Enables eslint-plugin-html
Resolves #

馃搹 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@mmorel-35 mmorel-35 mentioned this pull request Dec 4, 2021
43 tasks
@knsv knsv merged commit 4459eb5 into develop Dec 11, 2021
@mmorel-35 mmorel-35 deleted the eslint-plugin/html branch December 11, 2021 11:59
@Yash-Singh1
Copy link
Member

Not sure why, but in our markdown files, HTML is still being considered as javascript and being formatted as if it was JSX. There are many weird situations where it is wrapping the text as if it is plain text that you would type in as content. There is an issue open on migrating eslint-plugin-html to the new processer API: BenoitZugmeyer/eslint-plugin-html#139. Also there is a comment related to this: BenoitZugmeyer/eslint-plugin-html#139 (comment). I guess we should disable eslint-plugin-html and leave embedded markdown formatting to prettier. For HTML, we can use @html-eslint though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants