Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error diagram rendering #1288

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Aug 17, 2023

📑 Summary

Removes the error diagram that's rendered at the bottom of the page.

Temporary fix for mermaid-js/mermaid#4730

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit e530b3e
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/6503e66e56615d000713812e
😎 Deploy Preview https://deploy-preview-1288--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Aug 17, 2023

1 failed test on run #1116 ↗︎

1 27 6 0 Flakiness 0

Details:

Merge e530b3e into 75ad46b...
Project: Mermaid Live Editor Commit: d30b291fa6 ℹ️
Status: Failed Duration: 02:32 💡
Started: Sep 15, 2023 5:09 AM Ended: Sep 15, 2023 5:11 AM
Failed  cypress/e2e/diagramUpdate.spec.ts • 1 failed test

View Output Video

Test Artifacts
Auto sync tests > supports editing code when code is incorrect Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

* develop:
  build: update Browserslist db
  Fix tests
  fix cypress
  chore(deps): update all non-major dependencies
  chore(deps): update all non-major dependencies
  Group mermaid release separately
  chore(deps): update all non-major dependencies
  build: update Browserslist db
  build: update Browserslist db
  Bump @adobe/css-tools from 4.3.0 to 4.3.1
  fix: add missing and remove duplicate keywords in pie
Copy link

This pr is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant