Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scss-config-webpack-plugin): Replace deprecated Node Sass with Sass #132

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

Nilsilino
Copy link

@Nilsilino Nilsilino commented Apr 20, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: link tbd.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] tooling / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 92

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@ernscht ernscht self-requested a review June 6, 2023 08:43
Copy link
Member

@ernscht ernscht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thank you. But I would see the change as "breaking".

Since we will have other breaking changes, we can still merge it.

@ernscht ernscht changed the base branch from master to develop June 6, 2023 08:46
@ernscht ernscht merged commit 2504140 into develop Jun 6, 2023
6 checks passed
codeengrpo added a commit to codeengrpo/webpack-config-plugins that referenced this pull request Jul 22, 2023
Merge pull request merkle-open#132 from merkle-open/feature/replace-node-sass-wi…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants