Skip to content

Commit

Permalink
Merge pull request #100 from merkle-open/bugfix/functional-mistakes
Browse files Browse the repository at this point in the history
Bugfix/functional mistakes
  • Loading branch information
ernscht committed Sep 10, 2021
2 parents 0adf94f + 9d679f3 commit dca5e53
Show file tree
Hide file tree
Showing 4 changed files with 49 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports = module.exports = (options) => ({
rules: [
{
// .ts, .tsx, .d.ts
test: /\.(tsx?|d.ts)$/,
test: /\.(tsx?|d\.ts)$/,
use: [
{
// enable file based cache
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports = module.exports = (options) => ({
rules: [
{
// .ts, .tsx, .d.ts
test: /\.(tsx?|d.ts)$/,
test: /\.(tsx?|d\.ts)$/,
use: [
{
// enable file based cache
Expand Down
46 changes: 46 additions & 0 deletions packages/ts-config-webpack-plugin/test/WebpackConfigFiles.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
const productionConfig = require('../config/production.config');
const developmentConfig = require('../config/development.config');

function filesRegexTests(filesRegex) {
it('files regex matches .ts file ending', (done) => {
expect(filesRegex.test('demo.ts')).toBe(true);
done();
});

it('files regex matches .tsx file ending', (done) => {
expect(filesRegex.test('demo.tsx')).toBe(true);
done();
});

it('files regex matches .d.ts file ending', (done) => {
expect(filesRegex.test('demo.d.ts')).toBe(true);
done();
});

it('files regex doesn\'t match "asdfts" (escaping the first dot)', (done) => {
expect(filesRegex.test('asdfts')).toBe(false);
done();
});

it('files regex doesn\'t match "asdftsx" (escaping the first dot)', (done) => {
expect(filesRegex.test('asdftsx')).toBe(false);
done();
});

it('files regex doesn\'t match "demo.dxts" (escaping the second dot)', (done) => {
expect(filesRegex.test('demo.dxts')).toBe(false);
done();
});
}

describe('TsConfigWebpackPlugin production config file', () => {
const filesRegex = productionConfig({}).module.rules[0].test;

filesRegexTests(filesRegex);
});

describe('TsConfigWebpackPlugin development config file', () => {
const filesRegex = developmentConfig({}).module.rules[0].test;

filesRegexTests(filesRegex);
});
2 changes: 1 addition & 1 deletion webpage/src/components/Configurator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function getInitialState() {
configOptionKeys.forEach((key) => {
result[key] = initial[key] === true;
});
return initial;
return result;
} catch {
return {};
}
Expand Down

0 comments on commit dca5e53

Please sign in to comment.