feat(parser): add onInsertedSemicolon option #252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
onInsertedSemicolon
callback option, matching the base behavior of theacorn
option of the same name. This option is used bywebpack
to identify when replacing the text of a node with a parenthesized expression would run afoul of a difference in runtime behavior if automatic semicolon insertion occurred.Motivating example:
If webpack replaces
foo
with the imported expression(0,some_module.foo)
, the resulting code has the runtime behavior ofOn the other hand, if webpack tries to always insert a semicolon, we instead have
Ultimately this is an issue because webpack doesn't perform all transforms on the AST layer and run the code through a printer for performance reasons.
The lack of this option is the one difference in behavior between
acorn
andmeriyah
that would potentially impact usingmeriyah
inwebpack
for a 20-30% AST parse performance boost.Adds a basic unit test for the feature.