Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment as a value for property definition #247

Merged
merged 3 commits into from Nov 1, 2023

Conversation

DimaIT
Copy link
Contributor

@DimaIT DimaIT commented Oct 31, 2023

Double assignment is not parsed correctly in class' property definition.

class A { b = c = d; } is parsed like class A { b = c; = d; } which is not a valid AST.

This PR fixes it along with other possible assignment operators.

@DimaIT DimaIT force-pushed the fix-property-double-assignment branch from 5a3ee73 to a40e4a5 Compare October 31, 2023 17:30
Copy link
Member

@3cp 3cp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@3cp 3cp merged commit f564914 into meriyah:master Nov 1, 2023
3 checks passed
@3cp
Copy link
Member

3cp commented Nov 1, 2023

v4.3.8 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants