Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add uuid dependency #356

Merged
merged 1 commit into from Aug 15, 2022
Merged

fix: add uuid dependency #356

merged 1 commit into from Aug 15, 2022

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Jun 7, 2022

Fixes #355. @merencia node-cron 3.0.1 breaks for project that doesn't have uuid as a dependency, this PR is an urgent patch.

EDIT: Closes #357 as well

package.json Outdated Show resolved Hide resolved
Fixes: #355
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@pSnehanshu
Copy link

I have installed v3.0.1, but the problem still persists. The temporary solution is to install uuid separately.

npm install uuid

@Juneezee
Copy link
Contributor Author

@pSnehanshu The problem was introduced in v3.0.1. v3.0.0 does not have this problem.

@cjosue15
Copy link

any update? :/

Oaphi added a commit to samliew/se-electionbot that referenced this pull request Jul 9, 2022
@merencia merencia merged commit f370a0d into node-cron:master Aug 15, 2022
@merencia
Copy link
Member

released on version 3.0.2

@merencia
Copy link
Member

@Juneezee thanks for the bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing dependency: uuid Bug with uuid dependency in node-cron@3.0.1
5 participants