Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-cron to 3.0.2 #15234

Merged
merged 4 commits into from Aug 25, 2022
Merged

Update node-cron to 3.0.2 #15234

merged 4 commits into from Aug 25, 2022

Conversation

tenebrius
Copy link
Contributor

@tenebrius tenebrius commented Aug 24, 2022

Description

Node-cron 3.0.1 does not list its 'uuid' dependency in its package.json which creates a 'Module not found' error if pnpm -r install --production && cli.js start is used.
Node-cron 3.0.2 recently fixed this by adding uuid as a dependency

Fixes #

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@paescuj
Copy link
Member

paescuj commented Aug 24, 2022

@tenebrius You should run pnpm --filter directus install node-cron@^3.0.2 to update the lock file as well.

Edit: Ah, and could you also update the types (@types/node-cron) to the same version? Thanks!

@rijkvanzanten rijkvanzanten added this to the Next Release milestone Aug 25, 2022
@rijkvanzanten rijkvanzanten self-assigned this Aug 25, 2022
@rijkvanzanten rijkvanzanten merged commit a98a83b into directus:main Aug 25, 2022
qborisb pushed a commit to qborisb/directus that referenced this pull request Aug 31, 2022
* Update node-cron to 3.0.2

* Update lockfile accordingly

* Fix lockfile resolution

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
qborisb pushed a commit to qborisb/directus that referenced this pull request Aug 31, 2022
* Update node-cron to 3.0.2

* Update lockfile accordingly

* Fix lockfile resolution

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants