feat: implement graphql-ws ping/pong #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why some other lines got reformatted, I ran |
|
I set it to draft while I verify some things. I'm still unsure if the However, at least this works Client -> Server and mercurius now responds properly. |
andreialecu
force-pushed
the
fix-pingpong
branch
from
7b4f4d0
to
bf2a28d
Compare
|
Confirmed to work bidirectionally. There was a minor issue that I fixed and force pushed. Notice by the arrows how some are incoming and some outgoing, but it works both ways.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #851
Here's a screenshot to confirm: