This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
Fix pluggable widgets tools native bundling #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diego-antonelli
previously approved these changes
Aug 25, 2020
mijay
reviewed
Aug 25, 2020
packages/tools/pluggable-widgets-tools/configs/tsconfig.base.json
Outdated
Show resolved
Hide resolved
mijay
reviewed
Aug 25, 2020
mijay
reviewed
Aug 26, 2020
packages/tools/pluggable-widgets-tools/configs/webpack.native.config.js
Outdated
Show resolved
Hide resolved
IIsaku
force-pushed
the
fix/pluggable-widgets-tools-native-bundling
branch
from
f2d76e1
to
9b3db33
Compare
mijay
reviewed
Aug 27, 2020
packages/pluggableWidgets/toggle-buttons-native/webpack.config.dev.js
Outdated
Show resolved
Hide resolved
mijay
previously approved these changes
Aug 27, 2020
diego-antonelli
suggested changes
Aug 27, 2020
packages/pluggableWidgets/toggle-buttons-native/webpack.config.prod.js
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/toggle-buttons-native/webpack.config.prod.js
Outdated
Show resolved
Hide resolved
mijay
previously approved these changes
Aug 28, 2020
- Remove devtool, since this is now set via gulp
- Change module to es2015, which allows webpack to tree shake widget code
- Change module for all ts widgets to esnext - For native ts widgets target esnext - Remove @babel/preset-env for native widgets, because RN will handle transpilation
- Native widgets now use native webpack config from PIW tools directly
- Webpack 4 cannot handle esnext output (optional chaining). Webpack 5 will support this.
- Find the actual module rule and append the babel plugin to it
- Optional chaining isn't supported in Webpack 4. With js code, babel-loader didn't transpile optional chaining. - All native widgets are now transpiled for RN runtime with metro-react-native-babel-preset
- Prettierignore didn't work properly for project path
IIsaku
force-pushed
the
fix/pluggable-widgets-tools-native-bundling
branch
from
92af9f7
to
1a8f4ad
Compare
diego-antonelli
suggested changes
Aug 31, 2020
- metro-react-native-babel-preset in PIW tools webpack config strips the flow types
mijay
approved these changes
Sep 1, 2020
leonardomendix
approved these changes
Sep 1, 2020
diego-antonelli
approved these changes
Sep 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pluggable-widgets-tools releasefor native widgets now creates bundles for production environments when there is no local webpack production config.esnextmodules, which allows Webpack to tree shake widget code before bundling. This can lead to smaller bundle sizes for all (web & native) widgets..prettierignore.