Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-5273: proxy: Fix websocket connection for advanced auth settings #907

Commits on Dec 10, 2021

  1. MEN-5273: proxy: Fix websocket connection for advanced auth settings

    By switching to the "enhanced" API for websocket.Dialer from
    mendersoftware's fork.
    
    There is a limitation in current gorilla/websocket.Dialer API in that
    the user cannot specify a dial method for TLS/TCP connections. The TLS
    handshake is always done by the library based on user's TLSClientConfig,
    but that is not enough for Mender as we need it to be done via OpenSSL
    (aka our dial wrapper for TLS) so that advance auth features like
    getting the keys from HSM.
    
    This commit switches to mendersoftware's fork and modifies the code
    accordingly (one line change!).
    
    The patch has been submitted upstream. See:
    * gorilla/websocket#745
    * gorilla/websocket#746
    
    Changelog: None
    No changelog, commit 84204a3 claims to support websockets, this commit
    just fixes a bug there which has not been released.
    
    Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
    lluiscampos committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    b657deb View commit details
    Browse the repository at this point in the history