[requirements.txt]: Downgrade idna to < 3.0 #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed, since the requests library does not yet support `idna > 2.x`. See this for information: psf/requests#5710 This shows up in Alpine containers during install as: ``` ERROR: Cannot install -r tests/integration/mender_integration/tests/requirements/python-requirements.txt (line 54) and idna==3.1 because these package versions have conflicting dependencies. The conflict is caused by: The user requested idna==3.1 requests 2.25.1 depends on idna<3 and >=2.5 ``` But not in containers with these dependencies already installed. Like this is from a `mender-qa` pipeline from a container running on the `docker` image: ``` Requirement already satisfied: idna==3.1 in /usr/lib/python3.8/site-packages (from -r /builds/Northern.tech/Mender/integration/tests/requirements/python-requirements.txt (line 23)) (3.1) Requirement already satisfied: requests==2.25.1 in /usr/lib/python3.8/site-packages (from -r /builds/Northern.tech/Mender/integration/tests/requirements/python-requirements.txt (line 54)) (2.25.1) ``` This is due to the installation in the `requirements/apk-requirements.txt` file, already installing this, in some cases: ``` �[32;1m$ apk add $(cat ${WORKSPACE}/integration/tests/requirements/apk-requirements.txt)�[0;m (1/73) Installing readline (8.1.0-r0) . . . (55/73) Installing py3-idna (3.1-r0) ``` Never the less, the requirements file is still wrong. Changelog: None Signed-off-by: Ole Petter <ole.orhagen@northern.tech> (cherry picked from commit 81a5b35) Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
|
@oleorhagen, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". |
|
@mender-test-bot start pipeline |
|
Hello 😸 I created a pipeline for you here: Pipeline-297542104 Build Configuration Matrix
|
|
I fail to see the relation to the failure... merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed, since the requests library does not yet support
idna > 2.x.See this for information:
psf/requests#5710
This shows up in Alpine containers during install as:
But not in containers with these dependencies already installed.
Like this is from a
mender-qapipeline from a container running on thedockerimage:This is due to the installation in the
requirements/apk-requirements.txtfile,already installing this, in some cases:
Never the less, the requirements file is still wrong.
Changelog: None
Signed-off-by: Ole Petter ole.orhagen@northern.tech
(cherry picked from commit 81a5b35)
Signed-off-by: Ole Petter ole.orhagen@northern.tech