MEN-7061: Accepted tooltip disappeared right after device is accepted #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: MEN-7061 Changelog: None Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>
|
@mineralsfree, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
| @@ -265,7 +265,6 @@ export const Authorized = ({ | |||
| if (!acceptedCount) { | |||
| return; | |||
| } | |||
| dispatch(advanceOnboarding(onboardingSteps.DEVICES_ACCEPTED_ONBOARDING)); | |||
There was a problem hiding this comment.
did you check if there is another place doing dispatch(advanceOnboarding(onboardingSteps.DEVICES_ACCEPTED_ONBOARDING));?
otherwise step might not be changed
There was a problem hiding this comment.
Yes, in order to proceed, the user should click a button on the tooltip with a hint, that says "Yes, let's deploy!", or, alternatively click on "Dismiss the tutorial".
aleksandrychev
approved these changes
May 2, 2024
mzedel
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: MEN-7061
Changelog: None