Skip to content

Commit

Permalink
test: Continue to coverage if external tests fail
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed May 31, 2022
1 parent 999e10b commit 85ae491
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Expand Up @@ -11,7 +11,7 @@ jobs:
tests:
name: Test on ${{ matrix.python-version }} (${{ matrix.tox-env }}${{ matrix.external && ', external' || '' }}) / ${{ matrix.os }}
runs-on: ${{ matrix.os }}
continue-on-error: false
continue-on-error: ${{ matrix.external || false }}
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -93,11 +93,11 @@ jobs:

- name: Combine coverage data and display human readable report
run: |
tox -e combine_coverage
poetry tox -e combine_coverage
- name: Create coverage report
run: |
tox -e coverage_xml
poetry tox -e coverage_xml
# TODO: requires setup in codecov.io. Doesn't need a token :)
# - name: Upload coverage report
Expand Down

0 comments on commit 85ae491

Please sign in to comment.