Basic GitHub CI with pytest #5987
Conversation
|
As of now, coverage files are not found. I'll drop for now, but would be great to reenable in future when we have time to debug: https://github.com/meltano/meltano/runs/6721113729
|
|
Exciting! @aaronsteers do you wanna disable the pytest on the gitlab side to cut down our build minute usage there or leave that enabled for a bit? |
.github/workflows/test.yml
Outdated
|
|
||
| - name: Run pytest | ||
| run: | | ||
| poetry run pytest -v --cov-report= --cov meltano -m "$PYTEST_MARKERS" |
There was a problem hiding this comment.
@aaronsteers this is awesome! fwiw you need to run coverage with the --parallel flag so the .coverage* file is generated. Otherwise there's no artifact to upload (this error):
Warning: No files were found with the provided path: .coverage.*. No artifacts will be uploaded.
| poetry run pytest -v --cov-report= --cov meltano -m "$PYTEST_MARKERS" | |
| poetry run coverage run --parallel -m pytest -m "$PYTEST_MARKERS" |
Similar to
https://github.com/meltano/sdk/blob/db90479f01d0426c380dd7d1b0234d4fbc9ec8e4/tox.ini#L17
There was a problem hiding this comment.
Also, it might be worth computing coverage in all our supported Python versions and then combine them in a single report, like we do in the SDK:
https://github.com/meltano/sdk/blob/db90479f01d0426c380dd7d1b0234d4fbc9ec8e4/tox.ini#L47
There was a problem hiding this comment.
@pandemicsyn re:
do you wanna disable the pytest on the gitlab side to cut down our build minute usage there or leave that enabled for a bit?
I think I'll hold off on removing those for now - just because I want to discuss the docker-image-dependent pytests and if we still need those. The pytest_fast could be dropped but I still like having that one as quick smoke check that doesn't take 20+ minutes to give a signal. I think we'll end up dropping them but want to make sure it's a thought-through decision.
🔮 Deploy Preview for meltano canceled.
|
- Use Python 3.9 - Do not use tox but raw Poetry instead
Adapted from @edgarrmondragon's recent work on the SDK: meltano/sdk#679
Bringing native GitHub pytest workflows, to allow us faster iteration.