Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pry v0.14 compatibility #14

Closed
wants to merge 1 commit into from
Closed

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Jan 26, 2023

@stanhu
Copy link
Contributor Author

stanhu commented Jan 26, 2023

Hmm, still getting:

  1) Pry::Shell has a version number
     Failure/Error: @pry = Pry::REPL.start_without_pry_byebug(frame._binding, Pry::Shell.active_shell_options)

     ArgumentError:
       wrong number of arguments (given 2, expected 1)
     # ./lib/pry/shell/patches/pry_byebug.rb:41:in `start_new_pry_session'
     # ./lib/pry/shell/patches/pry_byebug.rb:28:in `block in resume_pry'
     # ./lib/pry/shell/patches/pry_byebug.rb:27:in `resume_pry'
     # ./spec/pry/shell_spec.rb:6:in `block (2 levels) in <top (required)>'

@stanhu
Copy link
Contributor Author

stanhu commented Jan 27, 2023

Still trying to get this to work. @meinac Can you take a look?

@meinac
Copy link
Owner

meinac commented Jan 29, 2023

Thanks for working on this @stanhu! I've merged #15, could you please check if that fixed the issue?

@stanhu
Copy link
Contributor Author

stanhu commented Jan 30, 2023

@meinac I'm not sure if I'm doing this right, but pry-shell doesn't seem to show any available sessions.

@meinac
Copy link
Owner

meinac commented Jan 30, 2023

I'm not sure if I'm doing this right, but pry-shell doesn't seem to show any available sessions.

Are you setting the breakpoint with binding.pry_shell?

@meinac
Copy link
Owner

meinac commented Feb 8, 2023

Closing as fixed by #15. Thanks @stanhu!

@meinac meinac closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants