Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Cypress v5.0 (test-retries) #141

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kuceb
Copy link

@kuceb kuceb commented Aug 12, 2020

Hi, Cypress version 5.0 is landing soon, and included in that release is test-retries, which will break this plugin. Thankfully only a few changes were needed to support 5.0, so I've included them in this PR.

Although the changes in this PR will not break Cypress versions <5.0, This PR's tests will fail since it's expecting test-retries support. So I would recommend waiting for the Cypress 5.0 release and then updating to run against 5.0 before merging.

Note: this will also fix compatibility with cypress-plugin-retries (obsolete with 5.0)

Additional Info

to test against the 5.0 prerelease, I've used the following (Linux/docker):

export CYPRESS_INSTALL_BINARY=https://cdn.cypress.io/beta/binary/5.0.0/linux-x64/circle-test-retries-b0e7db25b4d6c91010b09f6ff4404bf5a7bcb74b-417938/cypress.zip
npm install --no-save https://cdn.cypress.io/beta/npm/5.0.0/circle-test-retries-b0e7db25b4d6c91010b09f6ff4404bf5a7bcb74b-417890/cypress.tgz

npm run cy:run # or cy:open

Edit

5.0 is released, I've added CI test runs for 5.0 in addition to previous versions of Cypress.

@kuceb kuceb changed the title support Cypress v5.0-prerelease (test-retries) fix: support Cypress v5.0-prerelease (test-retries) Aug 12, 2020
@meinaart
Copy link
Owner

Thanks for the work. I always tried to be backwards compatible. Have to think about if I want to break backwards compatibility. I do encourage users to keep up to date with latest Cypress version.

@kuceb
Copy link
Author

kuceb commented Aug 20, 2020

@meinaart This is backwards compatible. However the tests for the plugin will fail on a previous Cypress version. I'll add some code to test on multiple Cypress versions

@kuceb kuceb changed the title fix: support Cypress v5.0-prerelease (test-retries) fix: support Cypress v5.0 (test-retries) Aug 20, 2020
@kuceb
Copy link
Author

kuceb commented Aug 20, 2020

@meinaart take a look at the changes to CI, I've added testing for previous versions of cypress and 5.0.

@jcasasg
Copy link

jcasasg commented Sep 29, 2020

+1

1 similar comment
@davidzambrana
Copy link

+1

@paolo-chiabrera
Copy link

+1
Any update on this? 🤞

@BioCarmen
Copy link

Any update?

@henetiriki
Copy link

Eagerly awaiting an update on this too :)

@reidmovis
Copy link

Hope we can get this merged soon!

@hariaw
Copy link

hariaw commented Mar 25, 2021

Any update on this? Would love to see it merged in, and looks ready to go? cc @meinaart

@edimitchel
Copy link

Any news here ?

@cloakedninjas
Copy link

Would be good to rebase this with latest master @bkucera

@francisco-polaco
Copy link

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet