Remove jsnext main #713
Merged
Remove jsnext main #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Dec 8, 2020
714: Move jest timeout outside test r=bidoubiwa a=bidoubiwa Because #713 also timeoud like usual I dig into the same problem again. I think maybe it is due to the fact that it is not the `tests` that timeout but the whole jest setup. So I tried following this stack overflow: https://stackoverflow.com/questions/49603939/message-async-callback-was-not-invoked-within-the-5000-ms-timeout-specified-by who suggests the following: > But this would be specific to the test. Or you can set up the configuration file for the framework. > >Configuring Jest > >// jest.config.js >module.exports = { > // setupTestFrameworkScriptFile has been deprecated in > // favor of setupFilesAfterEnv in jest 24 > setupFilesAfterEnv: ['./jest.setup.js'] >} > >// jest.setup.js >jest.setTimeout(30000) Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
curquiza
added
the
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsnext:mainis deprecated: rollup/plugins#81 (comment)Only rollup used to use it but rollup just decided to remove it as well: rollup/plugins#85
Should be merged after: #709