Fix umd build having no node interop #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was caused by changing the rollup typescript from the non-official
rollup-plugin-typescript2to the official one @rollup/rollup-typescript.Multiple libraries suggesting multiple bundles outputs (umd, cjs, ...) are using rollup-plugin-typescript2. Since some of the issues why we initially used this one were resolved, I made the change to go back to the official one.
Unfortunately do a lack of tests on the builds themselves I did not realise a new issue was introduced.
By rollbacking to the initial plugin we used, the problem seems to be fixed. Tests are added to ensure this.
fixes: #502
fixes: #501