Mark internal fields as transient

[axelrindle]

Pull Request

Related issue

Fixes #655

What does this PR do?

Gson has issues working with the class com.meilisearch.sdk.Index in Java 9 and higher. Specifically all the fields which hold a com.meilisearch.sdk.HttpClient. Marking those fields as transient excludes them from serialization and thus preventing the reflective access on JDK-internal types.

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

[curquiza]

Hello @axelrindle
thank very much for your PR

Can you add tests to the test suite?

[axelrindle]

I could need some assistance for adding tests to the suite. How exactly could I test this very specific scenario?

The InaccessibleObjectException only occurs starting with JDK 9, while the tests are run with JDK 1.8. There a StackOverflowError is thrown instead which I could assert...

[curquiza]

@axelrindle let's go with your test in this case

However both CIs are failing. Can you fix your PR?

[axelrindle]

@curquiza The linter should be happy now :)

[curquiza]

Hello @axelrindle
Both CI (linter and tests) are still failing

[axelrindle]

@curquiza Try again please ... I think I got it right now 😄

[curquiza]

Yeaaaaaaah it works

Next time you contribute, I will not have to approve the CI to run it and you will be able to see the CI result immediately. This is a security we added for first-time contribution 😊

bors merge

[meili-bors]

Build succeeded:

• integration-and-unit-tests
• linter