Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run clippy only on MSRV #362

Merged
merged 3 commits into from Aug 2, 2022
Merged

Run clippy only on MSRV #362

merged 3 commits into from Aug 2, 2022

Commits on Aug 2, 2022

  1. Run clippy only on MSRV 

    This patch reverts the matrix for the clippy job to only run clippy on
our MSRV instead of stable, beta and nightly.

The recurring issue with this was that lints started failing in PRs that
couldn't have been fixed in master yet, because master was never tested
with a clippy that new (in case of nightly).

1.56.1 is good enough for now.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
    @matthiasbeyer
    matthiasbeyer committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    336a34e View commit details
    Browse the repository at this point in the history

  2. Fix: Use float_cmp for testing floats 

    Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
    @matthiasbeyer
    matthiasbeyer committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    d54986c View commit details
    Browse the repository at this point in the history

  3. Fix json5 test: Remove artifact character 

    I am not sure what happened that these tests suddenly fail, or where the
artifact comes from...

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
    @matthiasbeyer
    matthiasbeyer committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    518a3ca View commit details
    Browse the repository at this point in the history