New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated gulp-util #5
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
9d9c487
sc: mod: gitignore file - package-lock.json
denOldTimer 8a01e7e
sc mod: package.json - add: dep. plugin-error
denOldTimer 1e96d21
sc mod: index.js - plugin-error repalcement for gutil.pluginError
denOldTimer 4b01228
sc mod: package.json - add: dep. fancy-log
denOldTimer b5d54a3
sc mod: index.js - fancy-log repalcement for gutil.log
denOldTimer cbe16ae
sc mod: package.json - add: dep. ansi-colors
denOldTimer 5b8a2df
sc mod: index.js - ansi-colors repalcement for gutil.colors
denOldTimer 979e1bf
sc mod: package.json - add: dep. vinyl
denOldTimer 999c510
sc mod: index.js - vinyl repalcement for gutil.File
denOldTimer 7e03338
sc mod: index.js - naming of log to fancyLog
denOldTimer aa32eb1
sc mod: index.spec.js - fancy-log to replace gutil.log
denOldTimer 202a411
sc mod: index.spec.js - vinyl to replace gutil.File
denOldTimer 6c49c54
sc mod: index.js - renaming var vinyl to File
denOldTimer d3cd080
sc mod: index.spec.js - renaming var vinyl to File
denOldTimer 171768e
sc mod: package.json - rm devDep. gulp-util
denOldTimer a45ada6
FancyLog
denOldTimer de83445
Merge branch 'master' into scorpiocoding
meeroslav File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,5 @@ node_modules/ | |
.settings | ||
npm-debug.log | ||
Desktop.ini | ||
Thumbs.db | ||
Thumbs.db | ||
package-lock.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to use
fancyLog.info
(everywhere in this package) because of this kind of test relying on Node's cache to patch shared dependencies. (fancyLog.log
does not exist)I personally consider it a bit brittle so I exposed the logger on the main module in another PR. Finally, a solution would be to use
proxy-require
to stubfancy-log
.