Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs-util: add type argument of MedusaRequest as query parameter for get requests #7359

Merged
merged 1 commit into from
May 20, 2024

Conversation

shahednasser
Copy link
Member

For GET API routes, add the parameters defined in the type argument of MeduasRequest or AuthenticatedMedusaRequest as query parameters instead of request-body parameters.

@shahednasser shahednasser requested a review from a team as a code owner May 17, 2024 12:22
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 0:22am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 17, 2024 0:22am
docs-ui ⬜️ Ignored (Inspect) May 17, 2024 0:22am
medusa-docs ⬜️ Ignored (Inspect) May 17, 2024 0:22am

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: 0c36934

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shahednasser shahednasser merged commit cd31228 into develop May 20, 2024
25 checks passed
@shahednasser shahednasser deleted the docs-utils/docblock-oas-infer-get-params branch May 20, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants