fix-3803 add prefix to client storage #3806
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillonstreator is attempting to deploy a commit to the Medplum Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test flake or did I break something 🤔 |
dillonstreator
commented
Jan 26, 2024
packages/core/src/storage.ts
Outdated
| } | ||
|
|
||
| clear(): void { | ||
| this.storage.clear(); | ||
| const keys = this.storage instanceof MemoryStorage ? this.storage.keys() : Object.keys(this.storage); |
There was a problem hiding this comment.
While Object.keys(this.storage) works for localStorage, this is not safe for any Storage implementation. Might need to create a new interface that extends Storage and adds a keys method.
There was a problem hiding this comment.
94daee9 is an attempt at solving this issue
dillonstreator
commented
Jan 26, 2024
…ements keys() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3803
Warning
This is a breaking change for any client that depends on the local storage key names
activeLogin&loginsand as such should be highly visible in release notes.