Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @rollup/plugin-terser #1143

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Use @rollup/plugin-terser #1143

merged 1 commit into from
Nov 4, 2022

Conversation

codyebberson
Copy link
Member

Like many projects, we used rollup-plugin-terser for Rollup minification.

Unfortunately, that project appears to be deprecated:

Which makes it incompatible with the recently released Rollup 3.x.

Last week, the Rollup team released an official terser plugin based on the old one: @rollup/plugin-terser.

By using this new official plugin, we can once again remove --legacy-peer-deps from all of the npm i and npm ci commands.

@codyebberson codyebberson requested a review from a team as a code owner November 4, 2022 18:34
@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
medplum-storybook ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 6:35PM (UTC)
medplum-www ✅ Ready (Inspect) Visit Preview Nov 4, 2022 at 6:35PM (UTC)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.137% when pulling 6f15089 on cody-fix-legacy-peer-deps into 20a4b9a on main.

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codyebberson codyebberson merged commit 49c47bb into main Nov 4, 2022
@codyebberson codyebberson deleted the cody-fix-legacy-peer-deps branch November 4, 2022 19:12
@reshmakh reshmakh added the self-host Features and fixes related to self hosting label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-host Features and fixes related to self hosting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants