feat: upgrade cosmos-sdk v0.45.4 #356

0xHansLee · 2022-06-22T11:46:33Z

Upgrade cosmos-sdk to `v0.45.4`

Final ver of each package

cosmos-sdk : v0.45.4
ibc-go : v2.0.3
wasmd : v0.24.0
wasmvm : v1.0.0-beta7

Main changes

SubtractsCoins and SetSupply are removed in x/bank module. So I modified x/burn module to burn coins using BurnCoins in x/bank module.
In v0.42.11, ibc module was in comsos-sdk, under x/. But it has been moved to its own repo.
The upgrade to v0.44 or upper(v0.45 as in this PR) can be done using upgrade handler as suggested in guide. So I've also registered upgrade handler in app.go under v2.2.0-alpha1
removed x/token module because the module is useless anymore as we discussed
added feegrant and authz modules

Main Breaking Changes

v0.43

Addresses no longer have a fixed 20-byte length
Upgrade module no longer supports time based upgrades
pruning=default 100 -> 362880 (to cover 21 days of 5s block)
(x/bank) remove SetSupply, SetBalance (safety issue)
(x/bank) remove Supply, SupplyI
(x/upgrade) add VersionMap argument to upgradeHandler
(codec) renaming codec (codec: Rename codec and marshaler interfaces cosmos/cosmos-sdk#9226)
(x/capability) Removed InitializeAndSeal(ctx sdk.Context) and replaced with Seal() (fix!: Capability Issue on Restart, Backport to v0.43 cosmos/cosmos-sdk#9836)
(x/bank) Supply is now stored and tracked as sdk.Coins (Index supply by denom cosmos/cosmos-sdk#8517)
Renamed the CLI flag --memo to --note (Rename memo to note inside CLI cosmos/cosmos-sdk#9134)
(x/bank) Fix legacy REST API GET /bank/total and GET /bank/total/{denom} in swagger (Fix legacy rest api cosmos/cosmos-sdk#8434)

v0.44.0

Remove broadcast & encode legacy REST endpoints (https://github.com/cosmos/cosmos-sdk/pull/10041/files#diff-094e34468fa719601092d33bcae58742cfb3baf49f0fcfd4e9d8c1c06a1d407d)

v0.44.4

Change the order of module migration by pushing x/auth to the end. Auth module depends on other modules and should be run last. We have updated the documentation to provide more details how to change module migration order. This is technically a breaking change, but only impacts updates between the upgrades with version change, hence migrating from the previous patch release doesn't cause new migration and doesn't break the state (fix: always move auth module migration to the end cosmos/cosmos-sdk#10608)

v0.45.0

(x/gov) Increase maximum proposal description size from 5k characters to 10k characters (feat!: x/gov: raise max description length to 10k chars cosmos/cosmos-sdk#10740)
requirement to add all modules to SetOrder{BeginBlocker, EndBlocker, InitGenesis, ExportGenesis} functions + order moudles (https://github.com/cosmos/cosmos-sdk/pull/10614/files)

v0.45.3

move unsafe-reset-all to tendermint subcommand

TODO

update medibloc/cosmos-sdk package after release. It is not released yet, so I'll update after merge and release this PR
check ibc url in swagger config.json

0xHansLee

Some comments to help your reviews. Thanks in advance

0xHansLee · 2022-06-23T00:40:44Z

app/ante.go

+// numbers, checks signatures & account numbers, and deducts fees from the first
+// signer.
+// Copied from wasmd, https://github.com/CosmWasm/wasmd/blob/v0.24.0/app/ante.go
+func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) {


This NewAnteHandler is to receive all positional params as ante.HandlerOptions struct. If required fields aren't set, throws error accordingly. (https://github.com/cosmos/cosmos-sdk/pull/8682/files)

Plus, referred wasm's NewAnteHandler. (https://github.com/CosmWasm/wasmd/blob/v0.24.0/app/ante.go)

0xHansLee · 2022-06-23T00:48:01Z

app/app.go

@@ -360,7 +389,7 @@ func New(
 	app.CrisisKeeper = crisiskeeper.NewKeeper(
 		app.GetSubspace(crisistypes.ModuleName), invCheckPeriod, app.BankKeeper, authtypes.FeeCollectorName,
 	)
-	app.UpgradeKeeper = upgradekeeper.NewKeeper(skipUpgradeHeights, keys[upgradetypes.StoreKey], appCodec, homePath)
+	app.UpgradeKeeper = upgradekeeper.NewKeeper(skipUpgradeHeights, keys[upgradetypes.StoreKey], appCodec, homePath, bApp)


Upgrade Keeper takes new argument ProtocolVersionSetter which implements setting a protocol version on baseapp. (cosmos/cosmos-sdk#8897)

0xHansLee · 2022-06-23T00:49:09Z

app/app.go

@@ -372,7 +401,7 @@ func New(

 	// Create IBC Keeper
 	app.IBCKeeper = ibckeeper.NewKeeper(
-		appCodec, keys[ibchost.StoreKey], app.GetSubspace(ibchost.ModuleName), app.StakingKeeper, scopedIBCKeeper,
+		appCodec, keys[ibchost.StoreKey], app.GetSubspace(ibchost.ModuleName), app.StakingKeeper, app.UpgradeKeeper, scopedIBCKeeper,


The IBC Keeper now takes in the Upgrade Keeper (https://github.com/cosmos/ibc-go/blob/main/docs/migrations/sdk-to-v1.md#ibc-keeper-changes)

0xHansLee · 2022-06-23T00:50:55Z

app/app.go

@@ -381,7 +410,7 @@ func New(
 		AddRoute(paramproposal.RouterKey, params.NewParamChangeProposalHandler(app.ParamsKeeper)).
 		AddRoute(distrtypes.RouterKey, distr.NewCommunityPoolSpendProposalHandler(app.DistrKeeper)).
 		AddRoute(upgradetypes.RouterKey, upgrade.NewSoftwareUpgradeProposalHandler(app.UpgradeKeeper)).
-		AddRoute(ibchost.RouterKey, ibcclient.NewClientUpdateProposalHandler(app.IBCKeeper.ClientKeeper))
+		AddRoute(ibchost.RouterKey, ibcclient.NewClientProposalHandler(app.IBCKeeper.ClientKeeper))


The ClientUpdateProposalHandler has been renamed to ClientProposalHandler. It handles both UpdateClientProposals and UpgradeProposals. (https://github.com/cosmos/ibc-go/blob/main/docs/migrations/sdk-to-v1.md#proposal-handler-registration)

0xHansLee · 2022-06-23T00:55:20Z

app/app.go

@@ -440,7 +462,7 @@ func New(
 		&app.IBCKeeper.PortKeeper,
 		scopedWasmKeeper,
 		app.TransferKeeper,
-		app.Router(),
+		app.MsgServiceRouter(),


Now, the wasm.NewKeeper takes MessageRouter interface which is defined in https://github.com/CosmWasm/wasmd/blob/3bc0bdeab3fa2b3f7de745622226ff36c2ec6d6a/x/wasm/keeper/handler_plugin.go#L25

0xHansLee · 2022-06-23T01:18:42Z

go.mod

@@ -39,4 +39,4 @@ replace google.golang.org/grpc => google.golang.org/grpc v1.33.2

 replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

-replace github.com/cosmos/cosmos-sdk => github.com/medibloc/cosmos-sdk v0.42.11-panacea.1
+//replace github.com/cosmos/cosmos-sdk => github.com/medibloc/cosmos-sdk v0.45.4-panacea.1


TODO: after release upgraded version of medibloc/cosmos-sdk for min-commission-rate, replace it

0xHansLee · 2022-06-23T01:22:43Z

x/burn/keeper/burn_test.go

@@ -45,20 +46,15 @@ func (suite *BurnTestSuite) BeforeTest(_, _ string) {
 	bankKeeper := suite.BankKeeper

 	for _, addr := range address {
-		err := bankKeeper.AddCoins(ctx, addr, initCoins)
+		// mint coins and send to each account
+		err := simapp.FundAccount(suite.BankKeeper, suite.Ctx, addr, initCoins)


AddCoins is deleted in x/bank, so replace to simapp.FundAccount to mint and send coins to the account

0xHansLee · 2022-06-23T01:23:56Z

x/burn/expected/expected.go

-package expected
-
-import (
-	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/cosmos/cosmos-sdk/x/bank/exported"
-)
-
-type BankKeeperI interface {
-	GetAllBalances(ctx sdk.Context, addr sdk.AccAddress) sdk.Coins
-
-	SubtractCoins(ctx sdk.Context, addr sdk.AccAddress, amt sdk.Coins) error
-
-	GetSupply(ctx sdk.Context) exported.SupplyI
-	SetSupply(ctx sdk.Context, supply exported.SupplyI)
-}


It seems to be not used, so deleted

0xHansLee · 2022-06-23T01:24:52Z

x/burn/types/expected_keepers.go

-	GetSupply(ctx sdk.Context) exported.SupplyI
-	SetSupply(ctx sdk.Context, supply exported.SupplyI)
+	BurnCoins(ctx sdk.Context, moduleName string, amt sdk.Coins) error
+	GetSupply(ctx sdk.Context, denom string) sdk.Coin


GetSupply in x/bank takes one more arg, denom, and returns Coin.

0xHansLee · 2022-06-23T01:31:55Z

x/aol/module.go

@@ -164,3 +164,6 @@ func (am AppModule) BeginBlock(_ sdk.Context, _ abci.RequestBeginBlock) {}
 func (am AppModule) EndBlock(_ sdk.Context, _ abci.RequestEndBlock) []abci.ValidatorUpdate {
 	return []abci.ValidatorUpdate{}
 }
+
+// ConsensusVersion implements AppModule/ConsensusVersion.
+func (AppModule) ConsensusVersion() uint64 { return 1 }


ConsensusVersion is a sequence number for state-breaking change of the module. It should be incremented on each consensus-breaking change introduced by the module. To avoid wrong/empty versions, the initial version should be set to 1.
(https://github.com/cosmos/cosmos-sdk/blob/ad9e5620fb3445c716e9de45cfcdb56e8f1745bf/types/module/module.go#L176)

0xHansLee · 2022-06-23T03:08:38Z

app/app.go

+			"oracle":       1,
+		}
+
+		app.IBCKeeper.ConnectionKeeper.SetParams(ctx, ibcconnectiontypes.DefaultParams())


For in-place ibc migration, a new param, MaxExpectedTimePerBlock, should be set.

(https://github.com/cosmos/ibc-go/blob/main/docs/migrations/sdk-to-v1.md#in-place-store-migrations)

0xHansLee · 2022-06-23T09:45:27Z

In this commit, default value of minimum-gas-prices is set to "5umed" as guided in our gitbook
We can also add other custom configs for Panacea for future.

…sdk-upgrade # Conflicts: # go.mod

gyuguen

Thank you for your hard working.
I left a few comment.

app/app.go

cmd/panacead/cmd/init.go

x/burn/keeper/burn.go

x/burn/keeper/burn_test.go

x/oracle/keeper/oracle_test.go

gyuguen

LGTM 👍

types/testsuite/suite.go

gyuguen · 2022-06-29T00:55:53Z

go.mod

@@ -3,35 +3,35 @@ module github.com/medibloc/panacea-core/v2
 go 1.15


I think it should be changed from 1.15 to 1.18.

1.18? not 1.17?
Cosmos-sdk v0.45.4 requires min ver of go of 1.17.

Aha, I was talking about looking at cosmos-sdk v0.45.6.
As you said, 1.17 seems to be correct. :)

The required minimum go version is updated in 79db4e4

youngjoon-lee

danke

inchori

LGTM 👍 Thanks for your effort!
When upgrading next time, I could try it.

0xHansLee · 2022-06-30T01:04:48Z

As I said offline, the version v2.2.0-alpha1(including upgrade handler) is only for upgrade from v2.1.0-alpha2.
When we release a new version of panacea and upgrade mainnet, we should register a new upgrade handler which enable to upgrade and migrate from v2.0.3.

feat: upgrade cosmos-sdk v0.45.4

27fc094

0xHansLee requested review from cl9200, youngjoon-lee, gyuguen and inchori as code owners June 22, 2022 11:46

0xHansLee self-assigned this Jun 22, 2022

hansol-medi added 4 commits June 22, 2022 21:11

fix swagger config.json

bf18cef

fix go lint

90a6767

refactor

1166b4a

refactor

532f9bd

0xHansLee commented Jun 23, 2022

View reviewed changes

hansol-medi added 2 commits June 23, 2022 17:33

update go.mod

40a80e1

fix cobra println bug & set default min gas prices in app.toml

511ae89

Merge remote-tracking branch 'origin/master' into ft/na/v0.44-cosmos-…

604301f

…sdk-upgrade # Conflicts: # go.mod

gyuguen reviewed Jun 28, 2022

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

cmd/panacead/cmd/init.go Outdated Show resolved Hide resolved

x/burn/keeper/burn.go Show resolved Hide resolved

x/burn/keeper/burn_test.go Outdated Show resolved Hide resolved

x/oracle/keeper/oracle_test.go Outdated Show resolved Hide resolved

gyuguen approved these changes Jun 28, 2022

View reviewed changes

fix

516fc95

gyuguen reviewed Jun 28, 2022

View reviewed changes

types/testsuite/suite.go Outdated Show resolved Hide resolved

fix

af30aae

gyuguen approved these changes Jun 28, 2022

View reviewed changes

gyuguen reviewed Jun 29, 2022

View reviewed changes

youngjoon-lee approved these changes Jun 29, 2022

View reviewed changes

inchori approved these changes Jun 29, 2022

View reviewed changes

upgrade min go ver

79db4e4

0xHansLee merged commit 664d546 into master Jun 30, 2022

0xHansLee deleted the ft/na/v0.44-cosmos-sdk-upgrade branch June 30, 2022 01:27

0xHansLee mentioned this pull request Jun 30, 2022

Upgrade Cosmos SDK to v0.45 #221

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrade cosmos-sdk v0.45.4 #356

feat: upgrade cosmos-sdk v0.45.4 #356

0xHansLee commented Jun 22, 2022 •

edited

0xHansLee left a comment

0xHansLee Jun 23, 2022

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022

0xHansLee Jun 23, 2022

0xHansLee Jun 23, 2022

0xHansLee Jun 23, 2022

0xHansLee Jun 23, 2022

0xHansLee commented Jun 23, 2022

gyuguen left a comment

gyuguen left a comment

gyuguen Jun 29, 2022

0xHansLee Jun 29, 2022

gyuguen Jun 29, 2022

0xHansLee Jun 30, 2022

youngjoon-lee left a comment

inchori left a comment

0xHansLee commented Jun 30, 2022

		@@ -3,35 +3,35 @@ module github.com/medibloc/panacea-core/v2
		go 1.15

feat: upgrade cosmos-sdk v0.45.4 #356

feat: upgrade cosmos-sdk v0.45.4 #356

Conversation

0xHansLee commented Jun 22, 2022 • edited

Upgrade cosmos-sdk to v0.45.4

Main changes

Main Breaking Changes

v0.43

v0.44.0

v0.44.4

v0.45.0

v0.45.3

TODO

0xHansLee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xHansLee Jun 23, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xHansLee Jun 23, 2022 • edited

Choose a reason for hiding this comment

0xHansLee Jun 23, 2022 • edited

Choose a reason for hiding this comment

0xHansLee Jun 23, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xHansLee commented Jun 23, 2022

gyuguen left a comment

Choose a reason for hiding this comment

gyuguen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youngjoon-lee left a comment

Choose a reason for hiding this comment

inchori left a comment

Choose a reason for hiding this comment

0xHansLee commented Jun 30, 2022

0xHansLee commented Jun 22, 2022 •

edited

Upgrade cosmos-sdk to `v0.45.4`

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022 •

edited

0xHansLee Jun 23, 2022 •

edited