fix(is/tabbable): add element types email and number in IOS #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcysutton @rodneyrehm |
|
Hey there! Interesting find. Here I was thinking we had covered all elements, but obviously we forgot about all the "new" input types. I've added those locally and ran the tests in browsers available to me at the moment:
The build infrastructure seems to have broken down since our last commit (3 years ago) and I'm currently lacking the time to resurrect this stuff. |
|
@rodneyrehm very very friendly ping :) |
|
@rodneyrehm |
|
@medialize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add element types
emailandnumberin IOS