Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constructor throw on invalid ports. #345

Merged
merged 6 commits into from Aug 8, 2017
Merged

Make constructor throw on invalid ports. #345

merged 6 commits into from Aug 8, 2017

Commits on Aug 2, 2017

  1. Make constructor throw on invalid ports. 

    This makes the behaviour consistent with port().
    @konstantinblaesi
    konstantinblaesi committed Aug 2, 2017
    Copy the full SHA
    362513b View commit details
    Browse the repository at this point in the history

  2. Add tests for port validation in constructor.

    @konstantinblaesi
    konstantinblaesi committed Aug 2, 2017
    Copy the full SHA
    dd6846b View commit details
    Browse the repository at this point in the history

  3. Add some basic validation in the constructor.

    @konstantinblaesi
    konstantinblaesi committed Aug 2, 2017
    Copy the full SHA
    7bfb89e View commit details
    Browse the repository at this point in the history

  4. Fix tests.

    @konstantinblaesi
    konstantinblaesi committed Aug 2, 2017
    Copy the full SHA
    520d29d View commit details
    Browse the repository at this point in the history

  5. Simplify URI.ensureValidPort().

    @konstantinblaesi
    konstantinblaesi committed Aug 2, 2017
    Copy the full SHA
    a90bbec View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. Make hostname requirement configuration via URI.hostProtocols. 

    Protocols listed in this array will require the user to specify a hostname. Oherwise URI.js' factory/constructor will throw a TypeError.
    @konstantinblaesi
    konstantinblaesi committed Aug 7, 2017
    Copy the full SHA
    dd40ca7 View commit details
    Browse the repository at this point in the history