Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated event listeners to use Marionette 2.4.x event names #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

peterzen
Copy link

No description provided.

@rodneyrehm
Copy link
Member

thx!

do you need me to merge this, or can you work with your branch for the time being? I'm considering letting this PR dangle until I get to rework the module…

a) please don't - ever - bump version numbers in pull requests
b) you're upgrading a Marionette 1 plugin to Marionette 2 - that certainly isn't a bug-fix release, but a major change. see marionette.migrate for more…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants