Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change webpack peer dependency to optional in loader #2440

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Change webpack peer dependency to optional in loader #2440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b177a2e
Add Rspack as an optional peer dependency of loader
chenjiahan Feb 13, 2024
ba81514
Apply suggestions from code review
chenjiahan Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,17 @@
"source-map": "^0.7.0"
},
"peerDependencies": {
"@rspack/core": "0.x || 1.x",
chenjiahan marked this conversation as resolved.
Show resolved Hide resolved
"webpack": ">=5"
},
"peerDependenciesMeta": {
"@rspack/core": {
"optional": true
},
chenjiahan marked this conversation as resolved.
Show resolved Hide resolved
"webpack": {
"optional": true
}
},
"devDependencies": {},
"scripts": {
"test": "npm run test-coverage",
Expand Down
5 changes: 2 additions & 3 deletions packages/loader/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[![Backers][backers-badge]][collective]
[![Chat][chat-badge]][chat]

webpack loader for MDX.
webpack / Rspack loader for MDX.
chenjiahan marked this conversation as resolved.
Show resolved Hide resolved

<!-- more -->

Expand All @@ -34,8 +34,7 @@ This package is a webpack loader to support MDX.

## When should I use this?

This integration is useful if you’re using webpack (or another tool that uses
webpack, such as Next.js).
This integration is useful if you’re using webpack or Rspack (or another tool that uses webpack, such as Next.js).
chenjiahan marked this conversation as resolved.
Show resolved Hide resolved

This integration can be combined with the Babel loader to compile modern
JavaScript features to ones your users support.
Expand Down