Add Solid to JSX section in Getting Started guide #2159

Djunnni · 2022-10-24T12:33:14Z

i add Solid to JSX in getting-started.server.mdx

I wrote it referring to the Solid-jsx contents.

could you check my PR? @wooorm

vercel · 2022-10-24T12:33:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
mdx	✅ Ready (Inspect)	Visit Preview	Oct 24, 2022 at 1:06PM (UTC)

wooorm

Couple of small things, otherwise looking good!

docs/docs/getting-started.server.mdx

wooorm · 2022-10-24T12:40:39Z

docs/docs/getting-started.server.mdx

@@ -137,6 +139,7 @@ For more info on the aforementioned tools, please see their dedicated sections:
 [¶ Svelte][svelte],
 [¶ Theme UI][themeui], or
 [¶ Vue][vue].
+[¶ Solid][solid],


Move this above Svelte. The list is sorted alphabetically.

Not sure if you’re still working on this or thought it was fixed. But to be as clear as possible: I meant: this line L144, should be above L141 (Svelte)! :)

docs/docs/getting-started.server.mdx

wooorm · 2022-10-24T13:09:27Z

Thanks @Djunnni! 😃

Djunnni · 2022-10-27T08:51:53Z

@wooorm
if you are okay, can i get "hacktoberfest-accepted" badges?

wooorm · 2022-10-27T09:57:21Z

I’ve added it on this issue.
However, this project does not really participate in hacktoberfest; we’ve had some bad experiences with crappy PRs (not like this PR!!) in the past.
So, unfortunately I’m not interested in adding the label to the repo (which they might still require for you to get credit for this PR). I hope you do get credit though!

Djunnni · 2022-10-27T11:14:15Z

thank you.
That's what happened. I'm sorry.

What the maintainers think of the hacktoberfest I got to know a little bit.
The purpose of the event is good, but it is sad that there are a lot of abuse cases and a lot of dirty PR.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mdx-js/react](https://mdxjs.com) ([source](https://togithub.com/mdx-js/mdx)) | [`2.1.5` -> `2.2.1`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.1.5/2.2.1) | [![age](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/compatibility-slim/2.1.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/confidence-slim/2.1.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mdx-js/mdx</summary> ### [`v2.2.1`](https://togithub.com/mdx-js/mdx/releases/tag/2.2.1) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.2.0...2.2.1) - [`e293eaf`](https://togithub.com/mdx-js/mdx/commit/e293eafa) Remove `assert/strict` for Node 14 **Full Changelog**: mdx-js/mdx@2.2.0...2.2.1 ### [`v2.2.0`](https://togithub.com/mdx-js/mdx/releases/tag/2.2.0) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.1.5...2.2.0) ##### Features - [`641eb91`](https://togithub.com/mdx-js/mdx/commit/641eb917) Add support JSX development runtime by [@remcohaszing](https://togithub.com/remcohaszing) in [mdx-js/mdx#2045 ##### Patches - [`3e0ab23`](https://togithub.com/mdx-js/mdx/commit/3e0ab236) Fix `@mdx-js/node-loader` from patching all runtimes ##### Docs - [`4a1415d`](https://togithub.com/mdx-js/mdx/commit/4a1415d2) Add note about use with `vite-plugin-react` - [`38c2d46`](https://togithub.com/mdx-js/mdx/commit/38c2d46a) Add note about `rollup@2` in Vite by [@ryuujo1573](https://togithub.com/ryuujo1573) in [mdx-js/mdx#2180 - [`caac5df`](https://togithub.com/mdx-js/mdx/commit/caac5df4) Update docs for `solid-js` supporting JSX - [`3a50cc3`](https://togithub.com/mdx-js/mdx/commit/3a50cc35) Add Solid to JSX section in Getting Started guide by [@Djunnni](https://togithub.com/Djunnni) in [mdx-js/mdx#2159 - [`1c83612`](https://togithub.com/mdx-js/mdx/commit/1c836126) Fix docs on types - [`2635caf`](https://togithub.com/mdx-js/mdx/commit/2635caf9) Replace deprecated Intellij plugin in docs by [@slorber](https://togithub.com/slorber) in [mdx-js/mdx#2178 **Full Changelog**: mdx-js/mdx@2.1.5...2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mdx-js/react](https://mdxjs.com) ([source](https://togithub.com/mdx-js/mdx)) | [`2.1.5` -> `2.2.1`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.1.5/2.2.1) | [![age](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/compatibility-slim/2.1.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@mdx-js%2freact/2.2.1/confidence-slim/2.1.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mdx-js/mdx</summary> ### [`v2.2.1`](https://togithub.com/mdx-js/mdx/releases/tag/2.2.1) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.2.0...2.2.1) - [`e293eaf`](https://togithub.com/mdx-js/mdx/commit/e293eafa) Remove `assert/strict` for Node 14 **Full Changelog**: mdx-js/mdx@2.2.0...2.2.1 ### [`v2.2.0`](https://togithub.com/mdx-js/mdx/releases/tag/2.2.0) [Compare Source](https://togithub.com/mdx-js/mdx/compare/2.1.5...2.2.0) ##### Features - [`641eb91`](https://togithub.com/mdx-js/mdx/commit/641eb917) Add support JSX development runtime by [@remcohaszing](https://togithub.com/remcohaszing) in [mdx-js/mdx#2045 ##### Patches - [`3e0ab23`](https://togithub.com/mdx-js/mdx/commit/3e0ab236) Fix `@mdx-js/node-loader` from patching all runtimes ##### Docs - [`4a1415d`](https://togithub.com/mdx-js/mdx/commit/4a1415d2) Add note about use with `vite-plugin-react` - [`38c2d46`](https://togithub.com/mdx-js/mdx/commit/38c2d46a) Add note about `rollup@2` in Vite by [@ryuujo1573](https://togithub.com/ryuujo1573) in [mdx-js/mdx#2180 - [`caac5df`](https://togithub.com/mdx-js/mdx/commit/caac5df4) Update docs for `solid-js` supporting JSX - [`3a50cc3`](https://togithub.com/mdx-js/mdx/commit/3a50cc35) Add Solid to JSX section in Getting Started guide by [@Djunnni](https://togithub.com/Djunnni) in [mdx-js/mdx#2159 - [`1c83612`](https://togithub.com/mdx-js/mdx/commit/1c836126) Fix docs on types - [`2635caf`](https://togithub.com/mdx-js/mdx/commit/2635caf9) Replace deprecated Intellij plugin in docs by [@slorber](https://togithub.com/slorber) in [mdx-js/mdx#2178 **Full Changelog**: mdx-js/mdx@2.1.5...2.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

docs: add Solid to JSX in getting-started.server.mdx

8091bbf

vercel bot deployed to Preview October 24, 2022 12:35 View deployment

wooorm reviewed Oct 24, 2022

View reviewed changes

style: update docs for remark-lint

a2014ef

vercel bot deployed to Preview October 24, 2022 12:48 View deployment

style: docs list is sorted alphabetically.

3468305

vercel bot deployed to Preview October 24, 2022 13:06 View deployment

wooorm approved these changes Oct 24, 2022

View reviewed changes

wooorm changed the title ~~docs: add Solid to JSX in getting-started.server.mdx~~ Add Solid to JSX section in Getting Started guide Oct 24, 2022

wooorm merged commit 3a50cc3 into mdx-js:main Oct 24, 2022

wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Oct 24, 2022

wooorm mentioned this pull request Oct 24, 2022

Add Solid to JSX in Getting started #2116

Closed

4 tasks

wooorm added the hacktoberfest-accepted Accepted as part of hacktoberfest label Oct 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Solid to JSX section in Getting Started guide #2159

Add Solid to JSX section in Getting Started guide #2159

Djunnni commented Oct 24, 2022

vercel bot commented Oct 24, 2022 •

edited

wooorm left a comment

wooorm Oct 24, 2022

Djunnni Oct 24, 2022

wooorm Oct 24, 2022

Djunnni Oct 24, 2022

wooorm commented Oct 24, 2022

Djunnni commented Oct 27, 2022

wooorm commented Oct 27, 2022

Djunnni commented Oct 27, 2022

Add Solid to JSX section in Getting Started guide #2159

Add Solid to JSX section in Getting Started guide #2159

Conversation

Djunnni commented Oct 24, 2022

vercel bot commented Oct 24, 2022 • edited

wooorm left a comment

Choose a reason for hiding this comment

wooorm Oct 24, 2022

Choose a reason for hiding this comment

Djunnni Oct 24, 2022

Choose a reason for hiding this comment

wooorm Oct 24, 2022

Choose a reason for hiding this comment

Djunnni Oct 24, 2022

Choose a reason for hiding this comment

wooorm commented Oct 24, 2022

Djunnni commented Oct 27, 2022

wooorm commented Oct 27, 2022

Djunnni commented Oct 27, 2022

vercel bot commented Oct 24, 2022 •

edited