big black superformat bang

[peterbe]

No description provided.

[peterbe]

Here's how I made this. I ran my gitfilesinflight command to get a list of .py files in open PRs. That gave me a list of 18 files and then I used git ls-files | rg '\.py' to get a list of all possible files. Then I took like this and ' '.join(paths) print out:

docker-compose exec web poetry run black docs/conf.py kuma/__init__.py kuma/api/__init__.py kuma/api/apps.py ...

[codecov-io]

Codecov Report

Merging #6440 into master will increase coverage by 1.27%.
The diff coverage is 94%.

@@            Coverage Diff             @@
##           master    #6440      +/-   ##
==========================================
+ Coverage   51.14%   52.41%   +1.27%     
==========================================
  Files         300      300              
  Lines       33181    32899     -282     
  Branches     1850     1859       +9     
==========================================
+ Hits        16969    17243     +274     
+ Misses      15654    15099     -555     
+ Partials      558      557       -1

Impacted Files	Coverage Δ
kuma/wiki/views/misc.py	42.37% <ø> (-9.56%)	⬇️
kuma/wiki/views/__init__.py	100% <ø> (ø)	⬆️
kuma/search/tests/test_views_admin.py	30.76% <ø> (+8.54%)	⬆️
kuma/wiki/tests/test_views_misc.py	50.81% <ø> (+14.99%)	⬆️
kuma/wiki/views/akismet_revision.py	36.95% <ø> (-11.83%)	⬇️
kuma/version/views.py	75% <ø> (ø)	⬆️
kuma/wiki/views/list.py	46.7% <ø> (+7.62%)	⬆️
kuma/wiki/tests/test_views_list.py	73.99% <ø> (+1.86%)	⬆️
kuma/wsgi.py	0% <ø> (ø)	⬆️
kuma/wiki/urls_untrusted.py	26.66% <ø> (-1.91%)	⬇️
... and 168 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1b2c7...379a4e7. Read the comment docs.

[callahad]

Awesome! Once CI passes I'll follow your steps and confirm I get the same results. If so, we can ship it :)

[peterbe]

So, I had to do a bunch of extra tuneups. I don't really get why. For example, the W504 error came up which I couldn't make any sense of. Then, out of frustration, I just ran black on those files again and it fixed itself. Perhaps a bug in black.

Also, it broke a bunch of flake8 things due to this bug: PyCQA/pycodestyle#815

So, I ran flake8 on all those files looking for E231 errors. THen I manually opened each and every file and manually removed those excess trailing commas.
To test that my manual intervention worked, I ran, for example:

black kuma/search/tasks.py && flake8 kuma/search/tasks.py

until it was all well.

Perhaps it's Friday afternoon but I don't quite get why I had to do this. Either way, I now lost track of my noble attempt to not mess with files in flight in open PRs. Truth be told, so many of those open PRs are depressingly stale and not all of them will become conflicting after this monster of a change.

[peterbe]

Let's use #6447 instead.