Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class static initialization block example #1918

Merged
merged 2 commits into from Oct 4, 2021

Conversation

hamishwillee
Copy link
Contributor

This adds examples for class static initialization block, added in FF93 . This will appear in docs here: mdn/content#9281

There is a lot that might be shown. This primarily just shows the syntax for declaring a block, and that it can access/declare a property using the this.

@Rumyra
Copy link
Contributor

Rumyra commented Sep 30, 2021

So my theories on tests failing are:

  • No new line at end of file (see review)
  • JSlint actually can't parse a static block(?)

I'm not sure of the implications of merging this if the second point is true 🤔

@hamishwillee
Copy link
Contributor Author

As per the discussion you had with Will:

Looks like it might be eslint/eslint#15016 ? If so I think we should disable eslint for this example, but remember to enable it again when support for static lands in eslint.

I am presuming no action from me. Happy to do this, but would need instruction on how.

@Rumyra Rumyra merged commit 847d4a2 into mdn:master Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants