Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals, part 10: atob() and btoa() #33619

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Conversation

skyclouds2001
Copy link
Contributor

Description

Motivation

Additional details

Related issues and pull requests

part of the #33019

@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:HTTP HTTP docs Content:Glossary Glossary entries Content:Firefox Content in the Mozilla/Firefox subtree size/m 51-500 LoC changed labels May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

Preview URLs (14 pages)
Flaws (2)

Note! 13 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/27
Title: Firefox 27 for developers
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/Object/typeMustMatch does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/ECMAScript_6_support_in_Mozilla
External URLs (3)

URL: /en-US/docs/Web/API/WorkerGlobalScope/btoa
Title: WorkerGlobalScope: btoa() method


URL: /en-US/docs/Web/API/WorkerGlobalScope/atob
Title: WorkerGlobalScope: atob() method


URL: /en-US/docs/Mozilla/Firefox/Releases/27
Title: Firefox 27 for developers

(comment last updated: 2024-05-31 14:58:46)

@skyclouds2001 skyclouds2001 marked this pull request as ready for review May 15, 2024 06:29
@skyclouds2001 skyclouds2001 requested review from a team as code owners May 15, 2024 06:29
@skyclouds2001 skyclouds2001 requested review from wbamberg, teoli2003 and chrisdavidmills and removed request for a team May 15, 2024 06:29
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@chrisdavidmills chrisdavidmills removed their request for review May 21, 2024 11:05
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your ongoing work on this project!

files/en-us/glossary/base64/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/base64/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/atob/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/atob/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/btoa/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/window/btoa/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/base64/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/base64/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/atob/index.md Outdated Show resolved Hide resolved
files/en-us/web/api/workerglobalscope/btoa/index.md Outdated Show resolved Hide resolved
Co-authored-by: wbamberg <will@bootbonnet.ca>
files/en-us/glossary/base64/index.md Outdated Show resolved Hide resolved
files/en-us/glossary/base64/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @skyclouds2001 !

@wbamberg wbamberg merged commit dd3048a into mdn:main Jun 3, 2024
9 checks passed
@skyclouds2001 skyclouds2001 deleted the atob-btoa branch June 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Glossary Glossary entries Content:HTTP HTTP docs Content:WebAPI Web API docs size/m 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants