Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CookieStoreManager): params of CookieStoreManager.subscribe method desc wrong #33583

Merged
merged 2 commits into from
May 15, 2024

Conversation

xyy94813
Copy link
Contributor

Description

CookieStoreManager subscribe method params desc wrong.

Motivation

Fix wrong desc.

Additional details

https://developer.mozilla.org/en-US/docs/Web/API/CookieStoreManager/subscribe#examples

Related issues and pull requests

None.

@xyy94813 xyy94813 requested a review from a team as a code owner May 13, 2024 14:55
@xyy94813 xyy94813 requested review from wbamberg and removed request for a team May 13, 2024 14:55
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs 0-5 LoC changed labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Preview URLs

(comment last updated: 2024-05-15 19:08:13)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you for the fix!

@wbamberg wbamberg merged commit b5a6ae4 into mdn:main May 15, 2024
8 checks passed
@xyy94813 xyy94813 deleted the hotfix/cookie-store-manager_sub_method branch May 16, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/xs 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants