-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about presentation attributes to css cascade #33482
Conversation
Preview URLs Flaws (1)URL:
(comment last updated: 2024-05-24 22:06:43) |
Thank you for filing the issue and submitting a PR to resolve it. HTML presentational attributes are HTML, not part of CSS and therefore not part of the CSS cascade. This also means there isn't a mention as to the impact of CSS layers on presentational attributes, and we don't need to mention something that doesn't exist. Also, the I do agree that a note about presentational attributes makes sense. Please feel free to add a note in the "Which CSS entities participate in the cascade section. As this area starts with "Only CSS property/value pair declarations participate in the cascade." this is the best place to add this. |
Shuffled stuff around! Happy to make more changes if there's a better way to communicate this =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better. I made some words order suggestions. if you're ok with them, feel free to commit. if you have better suggestions, those are absolutely welcome. Thank you!
@BeksOmega Have you had a chance to look at the suggestions? |
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Sorry about the delay! Committed your suggestions unchanged =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Mostly, congratulations on your first merged MDN content PR.
Welcome to the team!
Description
Adds information about presentational attributes to the CSS Cascade docs. Updated throughout the "Author styles" section.
Motivation
Presentational attributes seem very similar to inline styles, but they have a very different precedence. This keeps people from thinking they're the same and running into unexpected behaviors.
Additional details
Manually tested that this information is correct, since the CSS spec doesn't specify how presentational attributes interact with CSS layers.
Related issues and pull requests
Fixes #33402