New CSS guide: Understanding aspect ratio #33461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:CSS
|
Preview URLs (comment last updated: 2024-05-15 22:29:33) |
github-actions
bot
added
size/l
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks for the review @dipikabh |
This was referenced May 10, 2024
dipikabh
requested changes
May 10, 2024
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
|
@dipikabh Thanks for the review. Looks like we're close to there. |
dipikabh
requested changes
May 14, 2024
|
|
||
| ### Creating a circle based on the container size | ||
|
|
||
| The inline-size of non-replaced block-level elements is the size of their container's [content box](/en-US/docs/Web/CSS/box-edge#content-box). Because they have an size by default, they don't need to have an explicit size set for the `aspect-ratio` property to work. |
There was a problem hiding this comment.
"an size" in "Because they have an size by default" remains to be fixed
|
|
||
| ## See also | ||
|
|
||
| - [CSS box sizing](/en-US/docs/Web/CSS/CSS_box_sizing) module |
There was a problem hiding this comment.
Should we add this link https://developer.mozilla.org/en-US/docs/Learn/Performance/Multimedia#rendering_strategy_preventing_jank_when_loading_images here as "How to prevent jank when loading images" (it is currently only linked via the term "jank" on the page)
There was a problem hiding this comment.
It's only tangential, so i think that reference is enough. I'll be adding CLS content in a few weeks, so will link that instead when it's published.
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
estelle
commented
May 14, 2024
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
estelle
commented
May 14, 2024
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
estelle
commented
May 14, 2024
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/css/css_box_sizing/understanding_aspect-ratio/index.md
Outdated
Show resolved
Hide resolved
…index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
links to this new guide will be created in a separate PR.
(I've been having issues with git, so this is the 3rd attempt at this PR. Sorry for the spam)
Note the images are not loading in the preview. The iframes for the preview are on https://live.mdnyalp.dev/en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio/runner.html?id=original but the image is on https://pr33461.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/CSS_box_sizing/Understanding_aspect-ratio
Fixes openwebdocs/project#201