Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF115 URLSearchParams.has() and delete() value arg #27360

Merged

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jun 16, 2023

FF115 URLSearchParams.has() and URLSearchParams.delete() have a new optional value argument to go with the parameter name.
Without the value the methods match on all/any parameter that has the specified name. With the value argument they methods match on a parameter that has both the matching name and value.

This updates the documentation for the two methods.

Other docs work for this can be tracked in #27172

Fix #26604

@hamishwillee hamishwillee requested a review from a team as a code owner June 16, 2023 05:43
@hamishwillee hamishwillee requested review from Elchi3 and removed request for a team June 16, 2023 05:43
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jun 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

Preview URLs

External URLs (2)

URL: /en-US/docs/Web/API/URLSearchParams/delete
Title: URLSearchParams: delete() method


URL: /en-US/docs/Web/API/URLSearchParams/has
Title: URLSearchParams: has() method

(comment last updated: 2023-06-19 01:29:08)

Copy link
Contributor

@zloirock zloirock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core-js has a polyfill for this. Could you add a link?

@hamishwillee
Copy link
Collaborator Author

@zloirock Thanks. I've added core.js links to the items I'm touching here - not to "everything"

@hamishwillee
Copy link
Collaborator Author

@Elchi3 When you have a moment, can I please get this reviewed. No urgency.

@sideshowbarker sideshowbarker merged commit 92ae2da into mdn:main Jun 26, 2023
6 checks passed
@hamishwillee hamishwillee deleted the ff115_urlsearchparams_has_delete branch June 27, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document value argument to URLSearchParams's has() and delete()
3 participants