Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AbortSignal»throwIfAborted example code #15368

Merged
merged 1 commit into from Apr 26, 2022
Merged

Fix AbortSignal»throwIfAborted example code #15368

merged 1 commit into from Apr 26, 2022

Conversation

jopemachine
Copy link
Contributor

Summary

Fixing example code

Motivation

While making a PR about promise API with abort controller, I encountered a similar situation with the example.

Supporting details

https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/throwIfAborted#implementing_an_abortable_api

Related issues

Fixes #15348.

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@jopemachine jopemachine requested a review from a team as a code owner April 26, 2022 02:33
@jopemachine jopemachine requested review from wbamberg and removed request for a team April 26, 2022 02:33
@github-actions github-actions bot added the Content:WebAPI Web API docs label Apr 26, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/API/AbortSignal/throwIfAborted
Title: AbortSignal.throwIfAborted()
on GitHub
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/API/AbortSignal/throwIfAborted
Title: AbortSignal.throwIfAborted()
on GitHub

No new external URLs

@sideshowbarker sideshowbarker changed the title Fix AbortSignal.throwIfAborted example code Fix AbortSignal»throwIfAborted example code Apr 26, 2022
@sideshowbarker sideshowbarker merged commit 6299cfe into mdn:main Apr 26, 2022
@sideshowbarker
Copy link
Collaborator

Gyubong, thanks much, and congrats on landing your first docs change here — welcome aboard 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AbortSignal.throwIfAborted example seems not correct
2 participants
@jopemachine @sideshowbarker