Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NodeJS data for CustomEvent API #23120

Merged
merged 1 commit into from
May 21, 2024

Conversation

queengooborg
Copy link
Collaborator

This PR updates and corrects version values for NodeJS for the CustomEvent API. The data comes from the mdn-bcd-collector project (v10.10.6), using results collected via UnJS' runtime-compat project.

Check out the collector's guide on how to review this PR.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CustomEvent

Additional Notes: Exact versions obtained from Node docs: https://nodejs.org/docs/latest/api/events.html#class-customevent

This PR updates and corrects version values for NodeJS for the `CustomEvent` API. The data comes from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v10.10.6), using results collected via [UnJS' runtime-compat project](https://github.com/unjs/runtime-compat).

_Check out the [collector's guide on how to review this PR](https://github.com/openwebdocs/mdn-bcd-collector#reviewing-bcd-changes)._

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CustomEvent

Additional Notes: Exact versions obtained from Node docs: https://nodejs.org/docs/latest/api/events.html#class-customevent
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 17, 2024
@github-actions github-actions bot added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label May 17, 2024
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this quickly in node (v20.12.1) to confirm that new CustomEvent('foo', { detail: 'bar' }).detail is "bar".

@foolip foolip merged commit 89f1b7b into mdn:main May 21, 2024
5 checks passed
@queengooborg queengooborg deleted the api/CustomEvent/nodejs-corrections branch May 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants