-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate install from Git #21656
Reinstate install from Git #21656
Conversation
8499777
to
f68a985
Compare
f68a985
to
0a7c6a2
Compare
@queengooborg I'm very confused by your comment. What build artifacts are being tracked by Git here? I haven't touched |
Oh...I'm sorry, I misread what file is being touched. I thought you were updating |
Misread the changes this PR is performing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, now that I've properly read what exactly this PR is doing, this is LGTM. Apologies for the previous review, I panicked because I thought that .gitignore
was being updated, not .npmignore
.
Small nit: we could actually probably just remove .npmignore
altogether? Since we deploy from the build/ folder, the .npmignore
doesn't really have any effect.
Thanks, @queengooborg!
I'll put it on my to do list to experiment with this a bit. IIRC, in the absence of a |
Summary
Reinstate the option to install BCD from Git. This is useful to, for example, run analysis against the data of a BCD PR, before it's merged and released.
Test results and supporting details
npm install git+https://github.com/mdn/browser-compat-data.git
and attempt toimport
orrequire
BCD. 😢npm install git+https://github.com/ddbeck/browser-compat-data.git#installable-from-HEAD
and attempt toimport
orrequire
BCD. 😄Related issues
Regress originated at #16593.