Add start_crossover_tolerance option #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r simplex edge weights
2 tasks
|
I think we should wait. I suggest we do nothing not required by reviewers until the PR gets merged. We can change whatever we like after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
scipy#12043
What does this implement/fix?
start_crossover_tolerancechoosedual simplex edge weight optionsAdditional information
I know you just requested some reviewers to take a look, but looks like these changes got fast tracked upstream. Happy to let them sit here for now while reviews happen or we can try to get them in real quick. You might want to test out
start_crossover_toleranceto make it's doing what we think it's doing, I wasn't able to test it much.